Escape xml in delete() using ElementTree #358
Conversation
|
Note that this has the same functionality as [#356 ]. This version took the approach of using minimal changes building XML using ElementTree as the comments under [357] suggested The other version took the approach of making a more minimal change, building the XML using python strings like the delete() method did earlier. I have no preference which approach is approved -- they both generate the same XML. |
ramayer
force-pushed
the
escape_xml_in_delete_using_elementree
branch
from
5f0001e to
9c08400
Compare
ramayer
force-pushed
the
escape_xml_in_delete_using_elementree
branch
from
9c08400 to
b48eabd
Compare
|
My initial pull request failed the flake8 tests with too long lines and improper whitespace. I pushed an updated version this morning. |
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 91.52% 91.58% +0.06%
==========================================
Files 7 7
Lines 1369 1379 +10
==========================================
+ Hits 1253 1263 +10
Misses 116 116
Continue to review full report at Codecov.
|
A different approach to [#356] using ElementTree as suggested in a comment.
The pysolr .delete() method was not escaping special characters like <, >, and & in the XML it was generating. See issue [#357].
In particular attempts to delete documents by IDs like this:
would give error messages, and attempts to delete documents like this:
could delete more than you would have expected. This pull request (with test cases) escapes the IDs and Lucene Query Expressions in the XML generation step.