Escape special characters in the XML generated in the delete() method #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type pysolr .delete() method was not escaping special characters like <, >, and & in the XML it was generating.
In particular attempts to delete documents by IDs like this:
would give error messages, and attempts to delete documents like this:
could delete more than you would have expected. This pull request (with test cases) escape the IDs and Lucene Query Expressions in the XML generation step.