Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove excessive spaces (#531) #597

Merged
merged 1 commit into from
Mar 11, 2022
Merged

fix: Remove excessive spaces (#531) #597

merged 1 commit into from
Mar 11, 2022

Conversation

DmytroLitvinov
Copy link
Contributor

Resolves #531

Related to PR and that comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #597 (dbaacf9) into master (ffbe35b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          19       19           
  Lines         830      830           
  Branches      114      114           
=======================================
  Hits          608      608           
  Misses        198      198           
  Partials       24       24           
Impacted Files Coverage Δ
djangocms_text_ckeditor/utils.py 89.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbe35b...dbaacf9. Read the comment docs.

@DmytroLitvinov
Copy link
Contributor Author

Hi @vinitkumar , @marksweb ,
Could you please review MR?

Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit 38eb902 into django-cms:master Mar 11, 2022
@DmytroLitvinov DmytroLitvinov deleted the 531-fix-space branch March 11, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive space rendered after plugins returning tags causes comma etc. looks ugly
3 participants