Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive space rendered after plugins returning tags causes comma etc. looks ugly #531

Closed
sq9mev opened this issue May 15, 2020 · 1 comment · Fixed by #597
Closed

Excessive space rendered after plugins returning tags causes comma etc. looks ugly #531

sq9mev opened this issue May 15, 2020 · 1 comment · Fixed by #597

Comments

@sq9mev
Copy link

sq9mev commented May 15, 2020

Well, eg. used with djangocms_bootstrap4 Link plugin, an excessive space is rendered.
It looks ugly especially when comma or point is next to the link:

LinkText ,

Should be:

LinkText,

I'm not sure if it's djangocms_bootstrap4 issue or djangocms-text-ckeditor, but i think there may be lots of cases when this space is unwanted and cannot be removed, while it may be inserted by editor in Text plugin edit form.

My proposal is to strip spaces in _render_tag(). Pull request will be provided in a moment.

@jrief
Copy link
Collaborator

jrief commented Mar 24, 2021

Since this is rendered by the LinkPlugin, you should try to fix it there. djangocms-text-ckeditor isn't responsible for rendering links.

@jrief jrief closed this as completed Mar 24, 2021
fbyaguar pushed a commit to fbyaguar/djangocms-text-ckeditor that referenced this issue Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants