Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI and GitHub actions #24

Closed
ccoVeille opened this issue May 11, 2024 · 5 comments
Closed

Add CI and GitHub actions #24

ccoVeille opened this issue May 11, 2024 · 5 comments

Comments

@ccoVeille
Copy link
Contributor

I'm thinking about launching the tests, when they will be added, but also adding golangci-lint check.
@ccoVeille
Copy link
Contributor Author

The CI should be added before #23 get merged because code quality should be enforced before refactoring.

@ccoVeille
Copy link
Contributor Author

I can do it of course

ccoVeille added a commit to ccoveille-forks/theredditbandit-pman that referenced this issue May 11, 2024
@ccoVeille
ci: GitHub actions to run tests and golangci-lint
e540312 
See dhotrey#24
@ccoVeille ccoVeille mentioned this issue May 11, 2024
Merged
ccoVeille added a commit to ccoveille-forks/theredditbandit-pman that referenced this issue May 11, 2024
@ccoVeille
ci: GitHub actions to run tests and golangci-lint
1c318fa 
See dhotrey#24
ccoVeille added a commit to ccoveille-forks/theredditbandit-pman that referenced this issue May 11, 2024
@ccoVeille
ci: add GitHub action for checking typos
537a815 
See dhotrey#24
@ccoVeille ccoVeille mentioned this issue May 11, 2024
Merged
ccoVeille added a commit to ccoveille-forks/theredditbandit-pman that referenced this issue May 11, 2024
@ccoVeille
ci: add dependabot to GitHub Actions
3712689 
It will help to keep go dependencies (go.mod) up to date, but also will
make sure GitHub actions are also updated.

See dhotrey#24
@ccoVeille ccoVeille mentioned this issue May 11, 2024
Merged
@ccoVeille
Copy link
Contributor Author

I did 😄

ccoVeille added a commit to ccoveille-forks/theredditbandit-pman that referenced this issue May 11, 2024
@ccoVeille
ci: GitHub actions to run tests and golangci-lint
c60ac75 
See dhotrey#24
@dhotrey
Copy link
Owner

dhotrey commented May 12, 2024

Thanks a lot for adding CI , I merged all the PRs and GHA is working as expected without any extra configuration , I already have 3 PR's from dependabot for version updates

@dhotrey dhotrey closed this as completed May 12, 2024
@ccoVeille
Copy link
Contributor Author

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccoVeille @dhotrey