This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix(headerbar): Broken link to apps resource #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are accessing baseUrl/api/version/resource we need to go back two levels instead of only one.
|
Closing in favour of #53 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔢 Implementation
Since we are accessing
baseUrl/api/version/resourcewe need to go back two levels instead of only one.Right now it leads to a 404 when trying to access this resource since it's fetching
/api/dhis-web-commons/menu/getModules.action.📔 Additional notes
With
apiVersion=""the two-level nesting seems to work fine too, even though the header bar still not supports it (dhis2/app-runtime#15).