Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix: adjust resource action path in headerbar #53

Merged
merged 4 commits into from
Jul 9, 2019
Merged

fix: adjust resource action path in headerbar #53

merged 4 commits into from
Jul 9, 2019

Conversation

Mohammer5
Copy link
Contributor

No description provided.

@Mohammer5 Mohammer5 requested a review from varl July 4, 2019 09:02
varl
varl reviewed Jul 4, 2019
View reviewed changes
@amcgee amcgee mentioned this pull request Jul 4, 2019
Merged
@SferaDev SferaDev mentioned this pull request Jul 9, 2019
Closed
@varl
Copy link
Contributor

varl commented Jul 9, 2019

@Mohammer5 I pushed an update.

@varl varl changed the title chore: adjust resource path in headerbar story fix: adjust resource action path in headerbar Jul 9, 2019
@varl
Copy link
Contributor

varl commented Jul 9, 2019

Updated title so it triggers a release, as it fixes a bug.

@varl
Copy link
Contributor

varl commented Jul 9, 2019

Tested in Usage Analytics with naked and versioned end-points.

@amcgee amcgee mentioned this pull request Jul 9, 2019
Closed
@varl varl closed this Jul 9, 2019
@varl varl reopened this Jul 9, 2019
@amcgee amcgee self-requested a review July 9, 2019 14:14
amcgee
amcgee approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical to #65

@amcgee
Copy link
Member

amcgee commented Jul 9, 2019 •
edited
Loading

From #65:

It looks like we're going to want to change the server's response to getModules since it includes entries like this ../icons/dhis-web-maps.png. What's the timeline for moving away from an actions endpoint and to a true api endpoint? Hopefully we could normalize the responses better when making that transition.

@varl
Copy link
Contributor

varl commented Jul 9, 2019

@amcgee unknown timeline, but it is being worked on in: https://jira.dhis2.org/browse/DHIS2-7154

@varl varl merged commit 04fbdcd into master Jul 9, 2019
@varl varl deleted the Fix_api_path_custom_data_provider branch July 9, 2019 14:17
@varl
Copy link
Contributor

varl commented Jul 9, 2019

And yes, the API needs to change to return the logo from the App, and not serve up bundled images for those applications.

dhis2-bot pushed a commit that referenced this pull request Jul 9, 2019
chore(release): cut 1.0.8 [skip ci]
8bcf359 
## [1.0.8](v1.0.7...v1.0.8) (2019-07-09)

### Bug Fixes

* adjust resource action path in headerbar ([#53](#53)) ([04fbdcd](04fbdcd))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@varl varl varl approved these changes

@amcgee amcgee amcgee approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mohammer5 @varl @amcgee @dhis2-bot