Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format start/end dates #2544

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix: format start/end dates #2544

merged 1 commit into from
Mar 17, 2023

Conversation

turban
Copy link
Contributor

@turban turban commented Mar 17, 2023

We have switched to the HTML5 date picker which requires date to be in yyyy-mm-dd format. The dates returned from the API also include the time (2021-01-01T01:00:00.000 2022-10-01T02:00:00.000). This PR will strip the time part before passing the value to the date picker.

After this PR the dates show:

Screenshot 2023-03-17 at 16 32 35

@turban turban requested a review from jenniferarnesen March 17, 2023 15:38
@cypress
Copy link

cypress bot commented Mar 17, 2023

Passing run #1895 ↗︎

0 33 20 0 Flakiness 0

Details:

fix: format date value
Project: maps Commit: bd6bba82fd
Status: Passed Duration: 04:06 💡
Started: Mar 17, 2023 3:37 PM Ended: Mar 17, 2023 3:41 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@turban turban merged commit 8d05417 into master Mar 17, 2023
@turban turban deleted the fix/event-start-end-dates branch March 17, 2023 15:46
dhis2-bot added a commit that referenced this pull request Mar 17, 2023
## [1.30.17](v1.30.16...v1.30.17) (2023-03-17)

### Bug Fixes

* format date value ([#2544](#2544)) ([8d05417](8d05417))
* useDisconnectionStatus instead of useOnlineStatus ([#2540](#2540)) ([176f0e3](176f0e3))
* **deps:** bump deps for headerbar connection status ([#2542](#2542)) ([7d239f1](7d239f1))
* avoid infinite loop when opening event data table ([#2543](#2543)) ([b109b95](b109b95))
* check both id and mapViews when preparing the map configuration ([#2539](#2539)) ([fca0f4f](fca0f4f))
* wait for system settings to load before fetching/creating a map ([#2541](#2541)) ([18bf2f3](18bf2f3))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.30.17 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants