fix: avoid infinite loop when opening event data table #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
approved these changes
Mar 17, 2023
Passing run #1892 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
dhis2-bot
added a commit
that referenced
this pull request
Mar 17, 2023
## [1.30.17](v1.30.16...v1.30.17) (2023-03-17) ### Bug Fixes * format date value ([#2544](#2544)) ([8d05417](8d05417)) * useDisconnectionStatus instead of useOnlineStatus ([#2540](#2540)) ([176f0e3](176f0e3)) * **deps:** bump deps for headerbar connection status ([#2542](#2542)) ([7d239f1](7d239f1)) * avoid infinite loop when opening event data table ([#2543](#2543)) ([b109b95](b109b95)) * check both id and mapViews when preparing the map configuration ([#2539](#2539)) ([fca0f4f](fca0f4f)) * wait for system settings to load before fetching/creating a map ([#2541](#2541)) ([18bf2f3](18bf2f3))
|
🎉 This PR is included in version 1.30.17 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids an infinite loop when the data table was opened for an event data table with extended data.
This fix is to always check if the layer is already loading.
After this PR data table show with extended data: