Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add WasmStreaming::set_url and CompiledWasmModule::source_url #786

Merged
merged 1 commit into from
Sep 22, 2021
Merged

feat: Add WasmStreaming::set_url and CompiledWasmModule::source_url #786

merged 1 commit into from
Sep 22, 2021

Conversation

andreubotella
Copy link
Contributor

Needed for denoland/deno#12151

@andreubotella andreubotella mentioned this pull request Sep 22, 2021
Closed
ry
ry approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @andreubotella !

@ry ry merged commit b32d0b0 into denoland:main Sep 22, 2021
@andreubotella andreubotella deleted the wasm-set-url branch September 22, 2021 18:39
piscisaureus added a commit that referenced this pull request Sep 22, 2021
@piscisaureus
Revert "feat: WasmStreaming::set_url, `CompiledWasmModule::source_u…
b48b712 
…rl` (#786)"

This reverts commit b32d0b0.
@piscisaureus piscisaureus mentioned this pull request Sep 22, 2021
Closed
@andreubotella andreubotella mentioned this pull request Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreubotella @ry @piscisaureus