feat: Show the URL of streaming WASM modules in stack traces #12268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SGTM |
andreubotella
force-pushed
the
wasm-module-url
branch
from
49c1634 to
f539b05
Compare
WebAssembly modules compiled through `WebAssembly.compile()` and similar non-streaming APIs don't have a URL associated to them, because they have been compiled from a buffer source. In stack traces, V8 will use a URL such as `wasm://wasm/d1c677ea`, with a hash of the module. However, wasm modules compiled through streaming APIs, like `WebAssembly.compileStreaming()`, do have a known URL, which can be obtained from the `Response` object passed into the streaming APIs. And as per the developer-facing display conventions in the WebAssembly Web API spec, this URL should be used in stack traces. This change implements that. Closes denoland#12151.
andreubotella
force-pushed
the
wasm-module-url
branch
from
f539b05 to
4fc837f
Compare
|
CI is now passing, so this can now be reviewed. |
bartlomieju
approved these changes
Oct 10, 2021
There was a problem hiding this comment.
Thanks Andreu, this LGTM. @bnoordhuis does this pose any problems for Deploy integration?
|
I don't think so. Nothing that can't be trivially fixed anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly modules compiled through
WebAssembly.compile()and similar non-streaming APIs don't have a URL associated to them, because they have been compiled from a buffer source. In stack traces, V8 will use a URL such aswasm://wasm/d1c677ea, with a hash of the module.However, wasm modules compiled through streaming APIs, like
WebAssembly.compileStreaming(), do have a known URL, which can be obtained from theResponseobject passed into the streaming APIs. And as per the developer-facing display conventions in the WebAssembly Web API spec, this URL should be used in stack traces. This change implements that.Closes #12151.
This PR depends on denoland/rusty_v8#786, and won't run on CI until a release of rusty_v8 containing that commit, and the corresponding serde_v8 release, are published.