Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact building workflows #956

Merged
merged 12 commits into from
Mar 12, 2025
Merged

Fix artifact building workflows #956

merged 12 commits into from
Mar 12, 2025

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Mar 12, 2025

  • Use a local copy of the build_libs.dart script with some fixes
  • Remove (ios, arm) target, as this is not supported in Flutter

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:intl4x labels Mar 12, 2025
Copy link

github-actions bot commented Mar 12, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl4x None 0.11.1 0.11.2 0.11.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:intl 0.20.3-wip WIP (no publish necessary)
package:intl4x 0.11.2 ready to publish intl4x-v0.11.2
package:intl_translation 0.20.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem changed the title Remove ios arm target Fix artifact building workflows Mar 12, 2025
@mosuem mosuem requested a review from robertbastian March 12, 2025 14:59
@mosuem mosuem marked this pull request as ready for review March 12, 2025 14:59
@mosuem mosuem enabled auto-merge (squash) March 12, 2025 14:59
@@ -1,3 +1,7 @@
## 0.11.2

- Use locally modified build_tools.dart for building icu4x libs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is confusing, isn't this not using locally modified code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did modify build_tools.dart - or what do you mean?

}

// Copied from Dart's package:intl4x build.dart, see
// https://github.com/dart-lang/i18n/blob/main/pkgs/intl4x/hook/build.dart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is getting a bit cyclic 😃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I should delete this

@mosuem mosuem merged commit f681aa0 into main Mar 12, 2025
28 of 29 checks passed
@mosuem mosuem deleted the removeIOSArm branch March 12, 2025 16:44
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/6c770bf..c41b86b):
  c41b86b9  2025-03-12  Sam Rawlins  Remove reference to AugmentableElement, soon to be deleted (dart-lang/dartdoc#4016)
  5dbd403c  2025-03-10  Parker Lougheed  Utilize scss features in sidebar styles (dart-lang/dartdoc#4010)

http (https://github.com/dart-lang/http/compare/900da9f..001665e):
  001665e  2025-03-11  dependabot[bot]  Bump the github-actions group across 1 directory with 5 updates (dart-lang/http#1723)

i18n (https://github.com/dart-lang/i18n/compare/bdeec25..b09c822):
  b09c822  2025-03-12  Moritz  Dont check hashes on tag
  f681aa0  2025-03-12  Moritz  Fix artifact building workflows (dart-lang/i18n#956)
  2644c17  2025-03-11  Moritz  Small fixes to intl4x (dart-lang/i18n#955)
  6d680ad  2025-03-11  Copybara-Service  Merge pull request `#948` from kszczek:ignore-script-subtags
  88ab7a8  2025-02-20  Kamil Szczęk  feat(intl): ignore script subtags when canonicalizing locale strings

tools (https://github.com/dart-lang/tools/compare/d67cd00..9c53358):
  9c533582  2025-03-11  Parker Lougheed  [package_config] Prepare for 2.2.0 release (dart-lang/tools#2031)

webdev (https://github.com/dart-lang/webdev/compare/f485686..302b6db):
  302b6db6  2025-03-11  Srujan Gaddam  Remove reassemble invocation and publish 24.3.7 (dart-lang/webdev#2598)
  3e17660f  2025-03-11  Srujan Gaddam  [dwds] callServiceExtension should check all extensions and return kMethodNotFound when extension not found (dart-lang/webdev#2597)
  8f146a15  2025-03-05  Srujan Gaddam  Roll dwds to 24.3.7-wip and webdev to 3.7.2-wip (dart-lang/webdev#2596)
  2c1d147d  2025-03-04  Srujan Gaddam  Add pull request and id-token write permissions to publish.yaml (dart-lang/webdev#2595)
  8a8eaf1b  2025-03-04  Srujan Gaddam  Add hotReloadSourcesUri parameter to FrontendServerDdcLibraryBundleProvider and publish DWDS 24.3.6 (dart-lang/webdev#2594)

Change-Id: I9b7b16a0c8f62cd70e1eb76dea485bbef7b8be15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415300
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants