-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes to intl4x #955
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
File | Coverage |
---|---|
pkgs/intl4x/lib/src/hook_helpers/build_options.dart | 💔 Not covered |
pkgs/intl4x/lib/src/number_format/number_format_options.dart | 💚 26 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/6c770bf..c41b86b): c41b86b9 2025-03-12 Sam Rawlins Remove reference to AugmentableElement, soon to be deleted (dart-lang/dartdoc#4016) 5dbd403c 2025-03-10 Parker Lougheed Utilize scss features in sidebar styles (dart-lang/dartdoc#4010) http (https://github.com/dart-lang/http/compare/900da9f..001665e): 001665e 2025-03-11 dependabot[bot] Bump the github-actions group across 1 directory with 5 updates (dart-lang/http#1723) i18n (https://github.com/dart-lang/i18n/compare/bdeec25..b09c822): b09c822 2025-03-12 Moritz Dont check hashes on tag f681aa0 2025-03-12 Moritz Fix artifact building workflows (dart-lang/i18n#956) 2644c17 2025-03-11 Moritz Small fixes to intl4x (dart-lang/i18n#955) 6d680ad 2025-03-11 Copybara-Service Merge pull request `#948` from kszczek:ignore-script-subtags 88ab7a8 2025-02-20 Kamil Szczęk feat(intl): ignore script subtags when canonicalizing locale strings tools (https://github.com/dart-lang/tools/compare/d67cd00..9c53358): 9c533582 2025-03-11 Parker Lougheed [package_config] Prepare for 2.2.0 release (dart-lang/tools#2031) webdev (https://github.com/dart-lang/webdev/compare/f485686..302b6db): 302b6db6 2025-03-11 Srujan Gaddam Remove reassemble invocation and publish 24.3.7 (dart-lang/webdev#2598) 3e17660f 2025-03-11 Srujan Gaddam [dwds] callServiceExtension should check all extensions and return kMethodNotFound when extension not found (dart-lang/webdev#2597) 8f146a15 2025-03-05 Srujan Gaddam Roll dwds to 24.3.7-wip and webdev to 3.7.2-wip (dart-lang/webdev#2596) 2c1d147d 2025-03-04 Srujan Gaddam Add pull request and id-token write permissions to publish.yaml (dart-lang/webdev#2595) 8a8eaf1b 2025-03-04 Srujan Gaddam Add hotReloadSourcesUri parameter to FrontendServerDdcLibraryBundleProvider and publish DWDS 24.3.6 (dart-lang/webdev#2594) Change-Id: I9b7b16a0c8f62cd70e1eb76dea485bbef7b8be15 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415300 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Small bug regarding fraction digits parsing and allow no
hook
options key in the pubspec.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.