-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some Chrome flags to make the browser more suitable for testing #5310
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistFunctionality
Maintainability
Quality
User Experience
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - ran this PR on performance spec locally on Mac, and did not see warnings in Chrome's DevTools console any more
@flotwig Does this not fix this Docker issue? #350 Also, can you add a 'why' to the user facing changelog? I know these are necessary, but there aren't really any reasons detailing why this was necessary - user changing behavior after this is in place. If must affect something - that is not explained. |
No, it doesn't I don't think. Re: the other Docker issue (#3633), adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was --disable-dev-shm-usage removed?
@mattempyre If you look at commit 7247dcf, adding it causes a bunch of tests to fail. Someone just needs to spend the time to figure out why these failures occur and an appropriate fix. There is an open issue to add --disable-dev-shm-usage: #5336 |
Moved
--disable-dev-shm-usage
to a new issue: #5336User facing changelog
--disable-ipc-flooding-protection
,--disable-backgrounding-occluded-window
,--disable-breakpad
,--password-store=basic
, and--use-mock-keychain
have been added to the list of arguments passed to Chrome on startup.Additional details
This should improve the testing experience as described in the linked issues.