Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chromium flag --disable-ipc-flooding-protection #5132

Closed
jennifer-shehane opened this issue Sep 12, 2019 · 2 comments · Fixed by #5310
Closed

Add Chromium flag --disable-ipc-flooding-protection #5132

jennifer-shehane opened this issue Sep 12, 2019 · 2 comments · Fixed by #5310
Labels
browser: chrome type: unexpected behavior User expected result, but got another

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Sep 12, 2019

Current behavior:

Currently, some of our end-to-end tests for Cypress lock up when run in Chrome (oddly enough, this seemed to only affect MacOS??) They do not lock up in Electron. Where is stalls, this message is printed to the console.

jquery.js:7285 Throttling navigation to prevent the browser from hanging. See https://crbug.com/882238. Command line switch --disable-ipc-flooding-protection can be used to bypass the protection

Screen Shot 2019-09-12 at 11 37 03 AM

Desired behavior:

Disable IPC (Inter-process Communication) flooding protection in Cypress. This was also one of the flags mentioned in #3633 that Puppeteer automatically passes through their testing, so adding this would partially address this.

Steps to reproduce: (app code and test code)

In local development of Cypress:

cd packages/server
npm run test ./test/performance/cy_visit_performance_spec.js

Essentially what this test does is cy.visit() a url 100 times really really fast.

Additional information

From Chromiums code, trying to figure out what this flag actually does.

"Some javascript code can flood the inter process communication system. "
"This protection limits the rate (calls/seconds) at which theses function "
"can be used. This flag disables the protection. This flag is deprecated "
"and will be removed in Chrome 76. Use the switch "
"--disable-ipc-flooding-protection instead.";
// Disables the IPC flooding protection.
// It is activated by default. Some javascript functions can be used to flood
// the browser process with IPC. This protection limits the rate at which they
// can be used.
@jennifer-shehane jennifer-shehane changed the title Add Chromium flag -disable-ipc-flooding-protection Add Chromium flag --disable-ipc-flooding-protection Sep 12, 2019
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Sep 12, 2019
@jennifer-shehane jennifer-shehane added browser: chrome type: unexpected behavior User expected result, but got another labels Sep 12, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 10, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 10, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 10, 2019

The code for this is done in cypress-io/cypress#5310, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: chrome type: unexpected behavior User expected result, but got another
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant