Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: capture PR number for Azure #26215

Merged
merged 16 commits into from
Mar 29, 2023
Merged

fix: capture PR number for Azure #26215

merged 16 commits into from
Mar 29, 2023

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Mar 24, 2023 •
edited
Loading

Additional details

Capture SYSTEM_PULLREQUEST_PULLREQUESTNUMBER to display the value in the cloud.

Steps to test

How has the user experience changed?

PR Tasks

@estrada9166 estrada9166 changed the title feat: capture PR number for Azure chore: capture PR number for Azure Mar 24, 2023
@estrada9166 estrada9166 marked this pull request as ready for review March 24, 2023 15:39
@emilyrohrbough emilyrohrbough changed the title chore: capture PR number for Azure fix: capture PR number for Azure Mar 24, 2023
emilyrohrbough
emilyrohrbough reviewed Mar 24, 2023
View reviewed changes
cli/CHANGELOG.md Outdated
@@ -11,6 +11,9 @@ _Released 03/28/2023 (PENDING)_
**Misc:**

- Made some minor styling updates to the Debug page. Addresses [#26041](https://github.com/cypress-io/cypress/issues/26041).
- Capture the [Buildkite](https://buildkite.com/) CI provider's environment variable `BUILDKITE_RETRY_COUNT` to handle CI retries in the Cloud. Addressed in [25750](https://github.com/cypress-io/cypress/pull/25750).
- Capture the [Azure](https://azure.microsoft.com/) CI provider's environment variable [`SYSTEM_PULLREQUEST_PULLREQUESTNUMBER`](https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#system-variables-devops-services) to display the value in the Cloud. Addressed in [26215](https://github.com/cypress-io/cypress/pull/26215)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this to be either a bug fix or feature enhancement, not listed as a misc update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated it to be under Bugfixes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated it to be under Bugfixes

@cypress
Copy link

cypress bot commented Mar 24, 2023 •
edited
Loading

3 flaky tests on run #45087 ↗︎

0 5121 74 0 Flakiness 3

Details:

Merge branch 'develop' into alejandro/feat/get-pr-number-for-azure
Project: cypress Commit: 64a2324297
Status: Passed Duration: 13:42 💡
Started: Mar 29, 2023 6:05 PM Ended: Mar 29, 2023 6:18 PM
Flakiness  cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

emilyrohrbough
emilyrohrbough reviewed Mar 24, 2023
View reviewed changes
@emilyrohrbough
Copy link
Member

@estrada9166 Are there doc changes that need to go with this change? or do we already document this ENV?

1 similar comment
@emilyrohrbough
Copy link
Member

@estrada9166 Are there doc changes that need to go with this change? or do we already document this ENV?

@estrada9166 @emilyrohrbough
Update cli/CHANGELOG.md
8a99778 
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
@estrada9166
Copy link
Member Author

@estrada9166 Are there doc changes that need to go with this change? or do we already document this ENV?

@emilyrohrbough these env variables are not documented - we only document the ones related with the CI-BUILD-ID

@emilyrohrbough
Copy link
Member

@estrada9166 why wouldn't we document all envs we are capturing?

lmiller1990
lmiller1990 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine!

@lmiller1990
Copy link
Contributor

@estrada9166 why wouldn't we document all envs we are capturing?

I'm guessing we don't document things considered internal to CI providers - users should be able to move from CI to CI seamlessly, I think these env vars would be considered an implementation detail. Is there any value in adding something like this to the documentation?

emilyrohrbough
emilyrohrbough reviewed Mar 28, 2023
View reviewed changes
@estrada9166 @emilyrohrbough
Update cli/CHANGELOG.md
d20a185 
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
@elylucas
Copy link
Contributor

@estrada9166 why wouldn't we document all envs we are capturing?

as these are values captured during CI and sent to Cloud for our own purposes, I don't think they need to be publicly documented

@estrada9166 estrada9166 merged commit a5b0cad into develop Mar 29, 2023
@estrada9166 estrada9166 deleted the alejandro/feat/get-pr-number-for-azure branch March 29, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

@lmiller1990 lmiller1990 lmiller1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estrada9166 @emilyrohrbough @lmiller1990 @elylucas