Skip to content

Commit a5b0cad

Browse files
fix: capture PR number for Azure (#26215)
* feat: capture PR number for Azure * Update changelog * Update changelog * Update changelog * Update cli/CHANGELOG.md Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> * Remove space * Update cli/CHANGELOG.md Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> * Update CHANGELOG.md --------- Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
1 parent 9327170 commit a5b0cad

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

cli/CHANGELOG.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33

44
_Released 04/11/2023 (PENDING)_
55

6+
**Bugfixes:**
7+
8+
- Capture the [Azure](https://azure.microsoft.com/) CI provider's environment variable [`SYSTEM_PULLREQUEST_PULLREQUESTNUMBER`](https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#system-variables-devops-services) to display the linked PR number in the Cloud. Addressed in [#26215](https://github.com/cypress-io/cypress/pull/26215).
9+
610
**Dependency Updates:**
711

812
- Upgraded [`minimist`](https://www.npmjs.com/package/minimist) from `1.2.6` to `1.2.8` to address this [CVE-2021-44906](https://github.com/advisories/GHSA-xvch-5gv4-984h) NVD security vulnerability. Addressed in [#26254](https://github.com/cypress-io/cypress/pull/26254).
@@ -22,6 +26,7 @@ _Released 03/28/2023_
2226
- Changed the way that Git hashes are loaded so that non-relevant runs are excluded from the Debug page. Fixes [#26058](https://github.com/cypress-io/cypress/issues/26058).
2327
- Corrected the [`.type()`](https://docs.cypress.io/api/commands/type) command to account for shadow root elements when determining whether or not focus needs to be simulated before typing. Fixes [#26198](https://github.com/cypress-io/cypress/issues/26198).
2428
- Fixed an issue where an incorrect working directory could be used for Git operations on Windows. Fixes [#23317](https://github.com/cypress-io/cypress/issues/23317).
29+
- Capture the [Buildkite](https://buildkite.com/) CI provider's environment variable `BUILDKITE_RETRY_COUNT` to handle CI retries in the Cloud. Addressed in [#25750](https://github.com/cypress-io/cypress/pull/25750).
2530

2631
**Misc:**
2732

@@ -35,10 +40,6 @@ _Released 03/15/2023_
3540

3641
- Fixed a regression in Cypress [10](https://docs.cypress.io/guides/references/changelog#10-0-0) where the reporter auto-scroll configuration inside user preferences was unintentionally being toggled off. User's must now explicitly enable/disable auto-scroll under user preferences, which is enabled by default. Fixes [#24171](https://github.com/cypress-io/cypress/issues/24171) and [#26113](https://github.com/cypress-io/cypress/issues/26113).
3742

38-
**Misc:**
39-
40-
- Capture the [Buildkite](https://buildkite.com/) CI provider's environment variable `BUILDKITE_RETRY_COUNT` to handle CI retries in the Cloud. Addressed in [25750](https://github.com/cypress-io/cypress/pull/25750).
41-
4243
**Dependency Updates:**
4344

4445
- Upgraded [`ejs`](https://www.npmjs.com/package/ejs) from `3.1.6` to `3.1.8` to address this [CVE-2022-29078](https://github.com/advisories/GHSA-phwq-j96m-2c2q) NVD security vulnerability. Addressed in [#25279](https://github.com/cypress-io/cypress/pull/25279).

packages/server/lib/util/ci_provider.js

+1
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ const _providerCiParams = () => {
159159
'BUILD_BUILDNUMBER',
160160
'BUILD_CONTAINERID',
161161
'BUILD_REPOSITORY_URI',
162+
'SYSTEM_PULLREQUEST_PULLREQUESTNUMBER',
162163
]),
163164
awsCodeBuild: extract([
164165
'CODEBUILD_BUILD_ID',

packages/server/test/unit/util/ci_provider_spec.js

+2
Original file line numberDiff line numberDiff line change
@@ -1116,6 +1116,7 @@ describe('lib/util/ci_provider', () => {
11161116
BUILD_BUILDNUMBER: 'buildNumber',
11171117
BUILD_CONTAINERID: 'containerId',
11181118
BUILD_REPOSITORY_URI: 'buildRepositoryUri',
1119+
SYSTEM_PULLREQUEST_PULLREQUESTNUMBER: 'systemPullrequestPullrequestnumber',
11191120

11201121
BUILD_SOURCEVERSION: 'commit',
11211122
BUILD_SOURCEBRANCHNAME: 'branch',
@@ -1130,6 +1131,7 @@ describe('lib/util/ci_provider', () => {
11301131
buildBuildnumber: 'buildNumber',
11311132
buildContainerid: 'containerId',
11321133
buildRepositoryUri: 'buildRepositoryUri',
1134+
systemPullrequestPullrequestnumber: 'systemPullrequestPullrequestnumber',
11331135
})
11341136

11351137
return expectsCommitParams({

0 commit comments

Comments
 (0)