-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format special characters correctly #22537
Conversation
Thanks for taking the time to open a PR!
|
@rachelruderman I believe this should work |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-authored-by: Rachel <rachel@cypress.io>
Co-authored-by: Rachel <rachel@cypress.io>
@gitstart it looks like there's still some failures in the new tests: https://app.circleci.com/pipelines/github/cypress-io/cypress/40184/workflows/db1cfce2-2a2c-477a-a946-27aea19a2219/jobs/1650275/tests#failed-test-1 |
Hey @tbiethman @rachelruderman I'm sorry, I fell sick, been in the hospital for a number of days. I've fixed this. There was an extra space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitstart glad you're out of the hospital and feeling better! Thank you for your contribution 🌟
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Bugfixes:
Additional details
A number of users reported having faced this issue and that they needed a fix for it. Please refer to #5679 and #7419 for more context.
Only assertions using
to.match()
andto.equal()
with special characters are affected by this change, the rest of the assertions and content in the reporter will stay largely unaffected.This change checks for all messages containing
to match()
orto equal()
and then converts the message to markdown as before but this time it does not convert the assertion. It then wraps the assertion in<strong>${assertion}</strong>
to make it appear bold.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?