Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters wrongly displayed in runner UI assertions, formatted as markdown #5679

Closed
gustawx opened this issue Nov 13, 2019 · 8 comments · Fixed by #22537
Closed
Labels
good first issue Good for newcomers pkg/reporter This is due to an issue in the packages/reporter directory type: bug

Comments

@gustawx
Copy link

gustawx commented Nov 13, 2019

Current behavior:

cypress

Desired behavior:

Special characters properly displayed

Steps to reproduce: (app code and test code)

for e.g. use assertion with regex:
should('match', /width: (50.*|49.*|48.*)%;/)

Versions

3.6.1

@jennifer-shehane
Copy link
Member

Verified in 3.8.0.

it("prints", () => {
  cy.wrap('foo').should('match', /width: (50.*|49.*|48.*)%;/)
})

Screen Shot 2019-12-17 at 2 26 29 PM

This is due to our Command logging supporting markdown as explained here: #2134 (comment) So is an unfortunate side effect.

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Dec 17, 2019
@jennifer-shehane jennifer-shehane added pkg/reporter This is due to an issue in the packages/reporter directory stage: ready for work The issue is reproducible and in scope good first issue Good for newcomers type: bug and removed stage: ready for work The issue is reproducible and in scope labels Dec 17, 2019
@gerardjorgensen
Copy link

Hi, can I work on this?

@jennifer-shehane
Copy link
Member

@gerardjorgensen Yes we would love an open PR - even one that is a work in progress is fine. Check out our contributing doc and ask us if you get stuck.

@gerardjorgensen
Copy link

I'm unfortunately stuck figuring out where the special character is converted Markdown. I looked at https://github.com/cypress-io/cypress/blob/develop/packages/reporter/src/commands/command.tsx#L106 but from there I'm not sure where to go.

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane changed the title 3.6.1 Special characters wrongly displayed in runner UI assertions Special characters wrongly displayed in runner UI assertions, formatted as markdown May 20, 2020
@jennifer-shehane
Copy link
Member

This is still an issue in 9.5.3.

@cypress-bot cypress-bot bot added stage: backlog and removed stage: ready for work The issue is reproducible and in scope labels Apr 28, 2022
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: backlog labels Jun 9, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 14, 2022

The code for this is done in cypress-io/cypress#22537, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jul 14, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers pkg/reporter This is due to an issue in the packages/reporter directory type: bug
Projects
None yet
3 participants