-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ProjectLifecycleManager & general launchpad cleanup #19347
Merged
tgriesser
merged 82 commits into
10.0-release
from
tgriesser/10.0-release/refactor-lifecycle
Dec 22, 2021
Merged
feat: ProjectLifecycleManager & general launchpad cleanup #19347
tgriesser
merged 82 commits into
10.0-release
from
tgriesser/10.0-release/refactor-lifecycle
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cycle * 10.0-release: refactor: remove unused legacy 'rewriteRules' (#19338)
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…cycle * 10.0-release: build: remove syncRemoteGraphQL from codegen chore: fix incorrect type from merge build: allow work with local dashboard (#19376) chore: Test example recipes against chrome (#19362) test(unify): Settings e2e tests (#19324) chore(deps): update dependency ssri to 6.0.2 [security] (#19351) fix: spec from story generation, add deps for install (#19352) chore: Fix server unit tests running on mac by using actual tmp dir (#19350) fix: Add more precise types to Cypress.Commands (#19003) fix: Do not screenshot or trigger the failed event when tests are skipped (#19331) fix (#19262) fix: throw when writing to 'read only' properties of `config` (#18896) fix: close chrome when closing electron (#19322) fix: disable automatic request retries (#19161) chore: refactor cy funcs (#19080) chore(deps): update dependency @ffmpeg-installer/ffmpeg to v1.1.0 🌟 (#19300)
* fix dev server plugin * make open config component issue own query * correct config name * fix test * correctly propogate errors in run mode * types * add v-else * ensure projectRoot avail when checking legacy plugins * handle warnings * pass correct file * throw error instead of warning * fix config spec
2 tasks
…iesser/10.0-release/refactor-lifecycle
* adding an alert with a stack * fixing icon * cleanup * Fix TS errors Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
estrada9166
previously approved these changes
Dec 21, 2021
import ChooseExternalEditorModal from './ChooseExternalEditorModal.vue' | ||
|
||
gql` | ||
fragment OpenConfigFileInIDE on Query { | ||
query OpenConfigFileInIDE { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProjectLifecycleManager
setupNodeEvents
@packages/config
& associated APIs fromserver
into DataContext'preprocessor:close'
event handler being added more times than it should be inipc
dependency-tree
)Object.keys(require.cache).filter(s => !s.includes('/node_modules/')
to detect deps of depsdependency-tree
had a dependency ontypescript@3.x
so that is now gone from the bundle 🎉