Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove copy button when not available #19417

Merged
merged 8 commits into from
Dec 21, 2021

Conversation

elevatebart
Copy link
Contributor

Closes UNIFY-677

On Firefox, navigator.clipboard only work with https. When it works, it will display the button, if not it will not.

Additionally removed a few intlify warnings

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
jmeridth JM (Jason Meridth)
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 17, 2021

Thanks for taking the time to open a PR!

@JessicaSachs
Copy link
Contributor

Can you fix Shiki, too?

@elevatebart
Copy link
Contributor Author

@JessicaSachs you got it ;)

@cypress
Copy link

cypress bot commented Dec 17, 2021



Test summary

18355 0 218 0Flakiness 3


Run details

Project cypress
Status Passed
Commit eab1a3e
Started Dec 21, 2021 3:32 PM
Ended Dec 21, 2021 3:45 PM
Duration 12:23 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging-spec.ts Flakiness
1 ... > works with forceNetworkError
2 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart merged commit 427b167 into 10.0-release Dec 21, 2021
@elevatebart elevatebart deleted the elevatebart/fix/project-copy-button branch December 21, 2021 16:01
tgriesser added a commit that referenced this pull request Dec 21, 2021
…cycle

* 10.0-release:
  fix: remove copy button when not available (#19417)
  test: Adding tests for Page Top Nav workflows (#19375)
  fix: fuzzy sort accuracy (#19420)
tgriesser added a commit that referenced this pull request Dec 21, 2021
…er/10.0-release/refactor-lifecycle-ui

* tgriesser/10.0-release/refactor-lifecycle:
  fix: remove copy button when not available (#19417)
  test: Adding tests for Page Top Nav workflows (#19375)
  fix: fuzzy sort accuracy (#19420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants