-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): remove __vite__ route and default to unified runner #18909
feat(app): remove __vite__ route and default to unified runner #18909
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the test steps. All works great. Switching between browsers with the actual new UI is awesome!
`${clientRoute}assets/*`, | ||
`${clientRoute}shiki/*`, | ||
], (req, res) => { | ||
debug('proxying static assets %s, params[0] %s', req.url, req.params[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's ship it
* 10.0-release: feat: improve vite DX (#18937) feat: Use plugins on config files (#18798) BREAKING CHANGE: trigger major bump BREAKING CHANGE: trigger major bump fix: fix cypress/package.json crasher fix(breaking): change circle.yml to release binary fix: build-prod-ui deps before build-prod packages feat: implement spec list tree (#18901) chore: adding 10.0-release to the circle.yml build script (#18926) feat(app): remove __vite__ route and default to unified runner (#18909) fix: app layout + specs list review (#18862) feat(app): show previous versions (#18838) feat: scaffold integration files in app (#18763) feat: add footer to the settings (#18867) fix: Exit when both --e2e and --component flags are passed in (#18855)
It's time to say hello to the future. If you run
yarn dev
withLAUNCHPAD=1
, we serve the unified runner. No more__vite__
route.This also fixes a bug where we did not correctly serve the statically build
packages/app
. So now you can docd packages/driver && LAUNCHPAD=1 yarn cypress:open
and it will work as expected (open mode with unified app, but not using a dev server - this is how things will work in production).Testing
app
,launchpad
,driver
__vite__
; no such route exists on the front-end)