feat(app): show previous versions #18838
Conversation
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
| * ] | ||
| */ | ||
| async versions (n: number = 5): Promise<Version[]> { | ||
| const result = await execa(`npm`, [`view`, `cypress`, `time`, `--json`]) |
There was a problem hiding this comment.
Would we be better off using fetch on https://registry.npmjs.org/cypress and get the output?
This opening of a new process feels brittle.
@tgriesser what do you think?
There was a problem hiding this comment.
The mocks were out of date and we don't need to show n number of versions... I'm actually okay with this implementation though.
| @@ -1,14 +1,14 @@ | |||
| <template> | |||
| <TopNavList v-if="versionList"> | |||
| <TopNavList v-if="props.gql.versions"> | |||
There was a problem hiding this comment.
Why not keep the versionList as a computed?
It would make the template look cleaner (for my taste)
|
|
||
| <TopNavListItem class="px-16px py-8px min-w-240px pb-12px"> | ||
| <p class="text-gray-600 text-12px py-8px leading-normal"> | ||
| You're currently running an old version of Cypress. |
There was a problem hiding this comment.
Could we move this & other text to i18n?
| ), | ||
| }) | ||
|
|
||
| cy.get('[data-cy="topnav-version-list"]').click() |
There was a problem hiding this comment.
Now that we are passing in known test data, we could select this by the name of the version we expect to be shown.
* 10.0-release: feat: improve vite DX (#18937) feat: Use plugins on config files (#18798) BREAKING CHANGE: trigger major bump BREAKING CHANGE: trigger major bump fix: fix cypress/package.json crasher fix(breaking): change circle.yml to release binary fix: build-prod-ui deps before build-prod packages feat: implement spec list tree (#18901) chore: adding 10.0-release to the circle.yml build script (#18926) feat(app): remove __vite__ route and default to unified runner (#18909) fix: app layout + specs list review (#18862) feat(app): show previous versions (#18838) feat: scaffold integration files in app (#18763) feat: add footer to the settings (#18867) fix: Exit when both --e2e and --component flags are passed in (#18855)
https://cypress-io.atlassian.net/browse/UNIFY-384
Up to date:
Not up to date:
Gets the previous releases of Cypress using
npm viewand expose them via GraphQL.