Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create config package for config validation #18589

Merged
merged 75 commits into from
Nov 9, 2021
Merged
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
5443611
(feat): create config package for config validation in server & driver
emilyrohrbough Oct 20, 2021
045fde3
cleanup
emilyrohrbough Oct 20, 2021
14632cc
.
emilyrohrbough Oct 20, 2021
b92b3b1
add tests to config
emilyrohrbough Oct 21, 2021
dcfaa5b
clean up
emilyrohrbough Oct 21, 2021
a8e405e
missed update
emilyrohrbough Oct 21, 2021
c7440d1
Merge branch 'develop' into add-config-validation
emilyrohrbough Oct 21, 2021
acd4b77
fix obj overrding issue
emilyrohrbough Oct 21, 2021
8fb03ab
tests
emilyrohrbough Oct 21, 2021
f149559
dependencies
emilyrohrbough Oct 21, 2021
e723b03
update missed import
emilyrohrbough Oct 21, 2021
d843170
fixes one of the two test issues
emilyrohrbough Oct 22, 2021
a38fb6a
Merge branch 'develop' into add-config-validation
emilyrohrbough Oct 22, 2021
3fdd15c
dang. thought this had already been changed.
emilyrohrbough Oct 22, 2021
4bfcfae
clean up
emilyrohrbough Oct 22, 2021
5e52676
clean pu
emilyrohrbough Oct 22, 2021
d0a9967
Merge branch 'develop' into add-config-validation
emilyrohrbough Oct 22, 2021
82b1119
...
emilyrohrbough Oct 25, 2021
ba6d586
Merge branch 'develop' into add-config-validation
emilyrohrbough Oct 25, 2021
00fed44
Merge branch 'develop' into add-config-validation
emilyrohrbough Oct 25, 2021
91dfd3f
Merge branch 'develop' into add-config-validation
emilyrohrbough Oct 25, 2021
6826069
improve import variable name
emilyrohrbough Oct 26, 2021
f449b9d
clean up pkg.json
emilyrohrbough Oct 26, 2021
c64a652
add the codeframe / UI error logic for test overrides
emilyrohrbough Oct 28, 2021
eae59f8
reset this bit.
emilyrohrbough Oct 28, 2021
63d18cf
fix codeframe for mocha suites vs tests & nested blocks
emilyrohrbough Oct 29, 2021
402a393
inlint test config overrides with correct stack trace
emilyrohrbough Nov 1, 2021
f279e36
typo
emilyrohrbough Nov 1, 2021
904c22b
Merge branch 'develop' into add-config-validation
emilyrohrbough Nov 1, 2021
1af43ac
fix global config state
emilyrohrbough Nov 1, 2021
b4ce459
Merge branch 'develop' into add-config-validation
emilyrohrbough Nov 1, 2021
c3ec924
Merge branch 'develop' into add-config-validation
emilyrohrbough Nov 1, 2021
762470c
reset config as expected
emilyrohrbough Nov 1, 2021
3486ab1
fix compile/types test
emilyrohrbough Nov 2, 2021
eafacca
re-add common-tags used in tests
emilyrohrbough Nov 2, 2021
a12e5d2
dont lint compiled code.
emilyrohrbough Nov 2, 2021
ffc43c5
.
emilyrohrbough Nov 2, 2021
9e37c63
dep not dev dep
emilyrohrbough Nov 2, 2021
cd13f0e
Merge branch 'develop' into add-config-validation
emilyrohrbough Nov 2, 2021
2b517be
have not been able to reproduce test failures locally
emilyrohrbough Nov 2, 2021
953dacd
fix the typsescript compiling
emilyrohrbough Nov 3, 2021
e05ceb3
clean up tsc
emilyrohrbough Nov 3, 2021
d4d4354
Merge branch 'develop' into add-config-validation
emilyrohrbough Nov 3, 2021
39dadca
fix slow test threshold.
emilyrohrbough Nov 3, 2021
766502c
Merge branch 'add-config-validation' of https://github.com/cypress-io…
emilyrohrbough Nov 3, 2021
4a34493
fix
emilyrohrbough Nov 3, 2021
f0676e2
clean up
emilyrohrbough Nov 3, 2021
2e27112
aAH. fix broken system tests
emilyrohrbough Nov 4, 2021
ab89639
fix types & update snapshots
emilyrohrbough Nov 4, 2021
530e19d
Update navigation_spec.js
emilyrohrbough Nov 4, 2021
b351eda
PR comments
emilyrohrbough Nov 4, 2021
35fc415
intented for this to release with 9.0.0
emilyrohrbough Nov 4, 2021
8bdfd57
remove @packages/config build script & move all from src to lib
emilyrohrbough Nov 5, 2021
619ee85
update gitignore for compile .js files in lib
emilyrohrbough Nov 5, 2021
a28cd4f
Merge branch 'develop' into add-config-validation
emilyrohrbough Nov 5, 2021
c0a47ca
handle before/beforeEach hooks
emilyrohrbough Nov 8, 2021
eaead0d
fix event emitting & retries
emilyrohrbough Nov 8, 2021
4905d32
Merge branch 'add-config-validation' of https://github.com/cypress-io…
emilyrohrbough Nov 8, 2021
5cb2f5e
typo
emilyrohrbough Nov 8, 2021
f582b3c
fix import
emilyrohrbough Nov 8, 2021
f0d538a
revert local change that was checked in
emilyrohrbough Nov 8, 2021
b804ea3
revert change that would require Product Review & alters the behavior…
emilyrohrbough Nov 8, 2021
1052df3
fix driver errors that highlighted the beforeeach hook issue
emilyrohrbough Nov 8, 2021
537e583
update snapshots
emilyrohrbough Nov 8, 2021
84f53d1
fix runner:test:before:run:asyn event exec
emilyrohrbough Nov 8, 2021
d97e70f
Merge branch '9.0-release' into add-config-validation
emilyrohrbough Nov 8, 2021
2e62654
missed merge conflict
emilyrohrbough Nov 8, 2021
5bad91c
fix unit tests
emilyrohrbough Nov 8, 2021
b6b3e7c
system tests
emilyrohrbough Nov 8, 2021
db58a8c
.
emilyrohrbough Nov 8, 2021
5ddf2dd
update snapshot
emilyrohrbough Nov 8, 2021
f554233
snapshot
emilyrohrbough Nov 8, 2021
e4c351d
snapshots
emilyrohrbough Nov 8, 2021
7341dec
ahh firefox throws window.Error differently
emilyrohrbough Nov 9, 2021
1414fd7
missed from merging in matts node changes
emilyrohrbough Nov 9, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
.
emilyrohrbough committed Nov 2, 2021

Verified

This commit was signed with the committer’s verified signature.
emilyrohrbough Emily Wisniewski (Rohrbough)
commit ffc43c5867035408d8973a743afbfb1ffcbf4506
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ Cached Theme.pak
Cached Theme Material Design.pak

# from config
packages/config/lib
packages/config/src/*.js

# from data-context, compiled .js files
packages/data-context/src/**/*.js
7 changes: 3 additions & 4 deletions packages/config/package.json
Original file line number Diff line number Diff line change
@@ -3,10 +3,9 @@
"version": "0.0.0-development",
"description": "Config contains the configuration types and validation function used in the cypress electron application.",
"private": true,
"main": "lib/index.js",
"main": "src/index.js",
"scripts": {
"prebuild": "rm -rf lib; mkdir lib; cp src/*.js lib",
"build": "tsc --project .",
"build-prod": "tsc --project .",
"clean": "rm -rf lib",
"test": "yarn test-unit",
"test-debug": "yarn test-unit --inspect-brk=5566",
@@ -27,6 +26,6 @@
"snap-shot-it": "7.9.3"
},
"files": [
"lib"
"src"
]
}
3 changes: 0 additions & 3 deletions packages/config/tsconfig.json
Original file line number Diff line number Diff line change
@@ -6,7 +6,4 @@
"files": [
"./../ts/index.d.ts"
],
"compilerOptions": {
"outDir": "./lib"
}
}