feat: create config package for config validation #18589
Merged
+5,205
−1,193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
emilyrohrbough
changed the title
emilyrohrbough
requested review from
flotwig and
mjhenkes
and removed request for
a team
jennifer-shehane
requested review from
chrisbreiding
and removed request for
flotwig
flotwig
previously approved these changes
Nov 8, 2021
| @@ -160,7 +160,7 @@ export default function (Commands, Cypress, cy, state, config) { | |||
| // stuff, or handling this in the runner itself? | |||
| // Cypress sessions will clear cookies on its own before each test | |||
| Cypress.on('test:before:run:async', () => { | |||
| if (!Cypress.config.experimentalSessionSupport) { | |||
| if (!Cypress.config('experimentalSessionSupport')) { | |||
There was a problem hiding this comment.
was this causing a bug? since before this condition would always pass
|
@emilyrohrbough if this is breaking, the base branch should be updated to |
flotwig
added
type: breaking change
chrisbreiding
approved these changes
Nov 8, 2021
flotwig
approved these changes
Nov 8, 2021
7 tasks
tgriesser
added a commit
that referenced
this pull request
Nov 18, 2021
* develop: (329 commits) chore: Update Chrome (stable) to 96.0.4664.45 (#18931) fix: Loading of specs with % in the filename (#18877) chore: refactor `create` into class `$Cy` (#18715) chore: Update Chrome (beta) to 96.0.4664.45 (#18891) fix: flaky `system-tests-firefox` job (#18848) release 9.0.0 feat: ensure major release have conduit app wait on localhost:3000 fix install-required-node use --legacy-peer-deps feat: ensure major release fix darwin node install chore(driver): fix integration test retry configuration (#18643) feat(deps): update dependency electron to v15 🌟 (#18317) chore: Bind this correctly when setting response headers with cy.route() (#18859) feat: create config package for config validation (#18589) chore: patch `winston` to suppress `padLevels` warning (#18824) chore: test out major release build fix: remove outdated npm registry links (#18727) fix: Adding an existing command with `Cypress.Commands.add()` will throw an error (#18587) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a
packages/configpackage which provides the list of configuration options and their default values and validation functions. The majority of this work has been extracting the existing configuration logic out of thepackages/servermodule so it could also be used by thepackages/drivermodule during in-test configuration updates made viaCypress.config.User facing changelog
Add validation to in-test configuration updates made with
Cypress.config.How has the user experience changed?
User will be shown an error message if their tests attempts to update the cypress configuration with an invalid value. Previously, the configuration would silently be updated and could cause un-expected behaviors or appear to be broken.
Example as seen in #2918, setting the baseUrl to an
' 'is not a valid baseUrl value. After this change the following would be displayed:PR Tasks
cypress-documentation?