Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove x/params dependency in x/crisis #12491

Merged
merged 20 commits into from
Jul 12, 2022
Merged

feat: remove x/params dependency in x/crisis #12491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
42e4fff
WIP: params
atheeshp Jul 7, 2022
4612c9f
add msg server tests
atheeshp Jul 8, 2022
2440838
review changes
atheeshp Jul 8, 2022
068a10a
add tests
atheeshp Jul 8, 2022
fe70097
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/crisis_pa…
atheeshp Jul 8, 2022
c02ddc0
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/crisis_pa…
atheeshp Jul 11, 2022
fe05ed8
review
atheeshp Jul 11, 2022
3dd14fe
fix tests
atheeshp Jul 11, 2022
3bd2428
fix tests
atheeshp Jul 11, 2022
3d4e042
review
atheeshp Jul 11, 2022
befbbc0
fix tests
atheeshp Jul 11, 2022
14c5909
add migrations
atheeshp Jul 11, 2022
959921d
review
atheeshp Jul 11, 2022
18059a9
review changes
atheeshp Jul 11, 2022
5b3aef4
- new line
atheeshp Jul 11, 2022
fb92815
Merge branch 'main' into ap/crisis_params
alexanderbez Jul 11, 2022
a282cad
Merge branch 'main' into ap/crisis_params
mergify[bot] Jul 11, 2022
6fd494f
Merge branch 'main' into ap/crisis_params
julienrbrt Jul 11, 2022
025f4dd
Merge branch 'main' into ap/crisis_params
mergify[bot] Jul 11, 2022
42f2a77
Merge branch 'main' into ap/crisis_params
atheeshp Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/slashing) [#12399](https://github.com/cosmos/cosmos-sdk/pull/12399) Migrate `x/slashing` to self-managed parameters and deprecate its usage of `x/params`.
* (x/mint) [#12363](https://github.com/cosmos/cosmos-sdk/pull/12363) Migrate `x/mint` to self-managed parameters and deprecate it's usage of `x/params`.
* (x/distribution) [#12434](https://github.com/cosmos/cosmos-sdk/pull/12434) Migrate `x/distribution` to self-managed parameters and deprecate it's usage of `x/params`.
* (x/crisis) [#12445](https://github.com/cosmos/cosmos-sdk/pull/12445) Migrate `x/crisis` to self-managed parameters and deprecate it's usage of `x/params`.

### API Breaking Changes

Expand All @@ -73,6 +74,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/staking) [#12102](https://github.com/cosmos/cosmos-sdk/pull/12102) Staking keeper now is passed by reference instead of copy. Keeper's SetHooks no longer returns keeper. It updates the keeper in place instead.
* (linting) [#12141](https://github.com/cosmos/cosmos-sdk/pull/12141) Fix usability related linting for database. This means removing the infix Prefix from `prefix.NewPrefixWriter` and such so that it is `prefix.NewWriter` and making `db.DBConnection` and such into `db.Connection`
* (x/distribution) [#12434](https://github.com/cosmos/cosmos-sdk/pull/12434) `x/distribution` module `SetParams` keeper method definition is now updated to return `error`.
* (x/crisis) [#12445](https://github.com/cosmos/cosmos-sdk/pull/12445) `x/crisis` module `SetConstantFee` keeper method definition is now updated to return `error`.


### Bug Fixes
Expand Down
Loading