Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove x/params dependency in x/crisis #12491

Merged
merged 20 commits into from
Jul 12, 2022
Merged

feat: remove x/params dependency in x/crisis #12491

merged 20 commits into from
Jul 12, 2022

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 8, 2022

Description

Closes: #12445


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title wip: remove x/params dependency in x/crisis feat: remove x/params dependency in x/crisis Jul 11, 2022
@atheeshp atheeshp marked this pull request as ready for review July 11, 2022 11:58
@atheeshp atheeshp requested a review from a team as a code owner July 11, 2022 11:58
@atheeshp atheeshp requested a review from amaury1093 July 11, 2022 11:59
@atheeshp atheeshp requested a review from alexanderbez July 11, 2022 15:06
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #12491 (6fd494f) into main (137c909) will increase coverage by 0.00%.
The diff coverage is 71.42%.

❗ Current head 6fd494f differs from pull request most recent head 42f2a77. Consider uploading reports for the commit 42f2a77 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12491   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files         691      693    +2     
  Lines       71768    71815   +47     
=======================================
+ Hits        46879    46912   +33     
- Misses      22254    22263    +9     
- Partials     2635     2640    +5     
Impacted Files Coverage Δ
x/crisis/keeper/genesis.go 16.66% <0.00%> (-23.34%) ⬇️
x/crisis/migrations/v046/migrate.go 60.00% <60.00%> (ø)
x/crisis/keeper/params.go 68.42% <66.66%> (+28.42%) ⬆️
x/crisis/keeper/migrator.go 71.42% <71.42%> (ø)
x/crisis/keeper/keeper.go 82.22% <100.00%> (+0.40%) ⬆️
x/crisis/keeper/msg_server.go 16.36% <100.00%> (+16.36%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️

@mergify mergify bot merged commit 7c1d743 into main Jul 12, 2022
@mergify mergify bot deleted the ap/crisis_params branch July 12, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/crisis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove param module from x/crisis
4 participants