Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict host compiler version based on CUDA version #55

Closed
wants to merge 3 commits into from
Closed

restrict host compiler version based on CUDA version #55

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b795e5b
restrict host compiler version based on CUDA version
kkraus14 Dec 8, 2020
a8ac66e
bump build number
kkraus14 Dec 8, 2020
6b79a91
MNT: Re-rendered with conda-build 3.20.5, conda-smithy 3.8.5, and con…
Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% set name = "nvcc" %}
{% set number = 7 %}
{% set number = 8 %}

package:
name: "{{ name }}"
Expand All @@ -20,22 +20,27 @@ outputs:
run_exports:
strong:
- cudatoolkit {{ cuda_compiler_version }}|{{ cuda_compiler_version }}.*
- __glibc >=2.17 # [linux and cuda_compiler_version == "11.0"]
- __glibc >=2.17 # [linux and (cuda_compiler_version or "").startswith("11.")]
requirements:
host:
# Needed to symlink libcuda into sysroot libs.
- {{ compiler("c") }}
- sysroot_linux-64 2.17 # [linux and cuda_compiler_version == "11.0"]
- __glibc >=2.17 # [linux and cuda_compiler_version == "11.0"]
- sysroot_linux-64 2.17 # [linux and (cuda_compiler_version or "").startswith("11.")]
- __glibc >=2.17 # [linux and (cuda_compiler_version or "").startswith("11.")]
run:
- sysroot_linux-64 2.17 # [linux and cuda_compiler_version == "11.0"]
- __glibc >=2.17 # [linux and cuda_compiler_version == "11.0"]
- sysroot_linux-64 2.17 # [linux and (cuda_compiler_version or "").startswith("11.")]
- __glibc >=2.17 # [linux and (cuda_compiler_version or "").startswith("11.")]
run_constrained:
- gcc_linux-64 <=10 # [linux and (cuda_compiler_version or "").startswith("11.1.")]
- gcc_linux-64 <=9 # [linux and (cuda_compiler_version or "").startswith("11.0.")]
- gcc_linux-64 <=8 # [linux and (cuda_compiler_version or "").startswith(("10.2.", "10.1."))]
- gcc_linux-64 <=7 # [linux and (cuda_compiler_version or "").startswith(("10.0.", "9.2."))]
Comment on lines +33 to +37
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using run constraints felt more appropriate than run dependencies to continue to allow people to bring their own compiler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work as the version is already set in the recipe's build variants, which conflicts.

My guess is we will need to use zip_keys with the cxx_compiler_version in conda-forge-pinning like what we have done already with docker_image. Though we can test this hypothesis out by adding a conda_build_config.yaml to the recipe here with the same change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit lost as to how I would go about doing this. Would I create a new key with say [9, 7, 7, 7, 9] to match the cuda_compiler_version keys? How would I make {{ compiler("c") }} play nicely with that since it seems to already be set by the earlier zip key?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to get that particular zip working: conda-forge/conda-forge-pinning-feedstock#1000

test:
requires:
- {{ compiler("c") }}
# Host code is forwarded to a C++ compiler
- {{ compiler("cxx") }}
- sysroot_linux-64 2.17 # [linux and cuda_compiler_version == "11.0"]
- sysroot_linux-64 2.17 # [linux and (cuda_compiler_version or "").startswith("11.")]
files:
- test.cu
- test_nvcc.sh # [linux]
Expand Down