-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict host compiler version based on CUDA version #55
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…da-forge-pinning 2020.12.07.18.58.57
run_constrained: | ||
- gcc_linux-64 <=10 # [linux and (cuda_compiler_version or "").startswith("11.1.")] | ||
- gcc_linux-64 <=9 # [linux and (cuda_compiler_version or "").startswith("11.0.")] | ||
- gcc_linux-64 <=8 # [linux and (cuda_compiler_version or "").startswith(("10.2.", "10.1."))] | ||
- gcc_linux-64 <=7 # [linux and (cuda_compiler_version or "").startswith(("10.0.", "9.2."))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using run constraints felt more appropriate than run dependencies to continue to allow people to bring their own compiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work as the version is already set in the recipe's build variants, which conflicts.
My guess is we will need to use zip_keys
with the cxx_compiler_version
in conda-forge-pinning
like what we have done already with docker_image
. Though we can test this hypothesis out by adding a conda_build_config.yaml
to the recipe
here with the same change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit lost as to how I would go about doing this. Would I create a new key with say [9, 7, 7, 7, 9]
to match the cuda_compiler_version
keys? How would I make {{ compiler("c") }}
play nicely with that since it seems to already be set by the earlier zip key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't manage to get that particular zip working: conda-forge/conda-forge-pinning-feedstock#1000
Closing as this approach won't work. Will open a PR in |
Sounds good. Yeah to your earlier question, we would need to combine them into the same |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Closes #51