Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to flann 1.9.2 #41

Merged
merged 14 commits into from
Oct 21, 2023
Merged

Update to flann 1.9.2 #41

merged 14 commits into from
Oct 21, 2023

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Oct 19, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

Running into issues in conda-forge/colmap-feedstock#24 because it uses C++17 which is not supported by flann 1.9.1

@Tobias-Fischer
Copy link
Contributor Author

Fix #28

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

Hi @conda-forge/flann @traversaro - I've gone down a rabbit hole and some downstream projects suddenly fail to compile because flann 1.9.1 doesn't support C++17 compilers; whereas 1.9.2 should. Unfortunately pkg-config can't find lz4 on Windows; I tried to pass directly the LZ4_LIBRARIES in c269611 but that didn't to the job. Do you have other ideas? Do we need to go via cmake?

@Tobias-Fischer
Copy link
Contributor Author

Hi @conda-forge/flann - this is ready for review.

Reminder for myself: We need to open a PR in the conda-forge-pinning-feedstock to bump the version once this is merged.

@traversaro
Copy link
Contributor

Thanks @Tobias-Fischer ! I will wait for comments for other maintainers (if any) and then I will merge.

@traversaro
Copy link
Contributor

Reminder for myself: We need to open a PR in the conda-forge-pinning-feedstock to bump the version once this is merged

In theory that is handled by the boys, together with opening a migration.

@Tobias-Fischer
Copy link
Contributor Author

Thanks @traversaro - talking about bots, do you know why they didn't open a PR with the version bump here?

@traversaro
Copy link
Contributor

Sorry for the late request, but can you also add the run_exports here? In this way we can remove this line: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/4421234e5eeadd98f9c91a696c5d1699f3094633/recipe/conda_build_config.yaml#L182 when we bump the library in conda-forge-pinning. I would do it myself but I am just with my mobile phone for a few days.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

@traversaro - good catch! All done.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/flann-feedstock/actions/runs/6597080421.

@traversaro
Copy link
Contributor

Thanks!

@traversaro traversaro merged commit d959584 into conda-forge:main Oct 21, 2023
@Tobias-Fischer Tobias-Fischer deleted the patch-1 branch October 21, 2023 19:01
@traversaro
Copy link
Contributor

Thanks @traversaro - talking about bots, do you know why they didn't open a PR with the version bump here?

No idea, in general errors in version update bots can be found in:

I do not see anything strange related to flann now, the output of the bot is:

2023-10-22T15:28:23.9382174Z 2023-10-22 15:28:23,937 INFO     conda_forge_tick.update_upstream_versions || itr  1286 - eta   227s: flann - 1.9.2 - 1.9.2

but once we have again the same problem, those two are the points that we should monitor.

@traversaro traversaro mentioned this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants