-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to flann 1.9.2 #41
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.10.18.15.50.16
Running into issues in conda-forge/colmap-feedstock#24 because it uses C++17 which is not supported by flann 1.9.1 |
Fix #28 |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.10.18.15.50.16
Hi @conda-forge/flann @traversaro - I've gone down a rabbit hole and some downstream projects suddenly fail to compile because flann 1.9.1 doesn't support C++17 compilers; whereas 1.9.2 should. Unfortunately pkg-config can't find |
Hi @conda-forge/flann - this is ready for review. Reminder for myself: We need to open a PR in the conda-forge-pinning-feedstock to bump the version once this is merged. |
Thanks @Tobias-Fischer ! I will wait for comments for other maintainers (if any) and then I will merge. |
In theory that is handled by the boys, together with opening a migration. |
Thanks @traversaro - talking about bots, do you know why they didn't open a PR with the version bump here? |
Sorry for the late request, but can you also add the run_exports here? In this way we can remove this line: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/4421234e5eeadd98f9c91a696c5d1699f3094633/recipe/conda_build_config.yaml#L182 when we bump the library in conda-forge-pinning. I would do it myself but I am just with my mobile phone for a few days. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@traversaro - good catch! All done. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/flann-feedstock/actions/runs/6597080421. |
Thanks! |
No idea, in general errors in version update bots can be found in:
I do not see anything strange related to flann now, the output of the bot is:
but once we have again the same problem, those two are the points that we should monitor. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)