Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fix-cuda-toolkit.patch + flann 1.9.2 #24

Merged
merged 15 commits into from
Oct 21, 2023
Merged

use fix-cuda-toolkit.patch + flann 1.9.2 #24

merged 15 commits into from
Oct 21, 2023

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Oct 18, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

See conda-forge/pycolmap-feedstock#10 for reasoning; they use the outdated CUDA cmake instead of CudaToolkit for downstream libraries, which causes issues in pycolmap.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Oct 18, 2023
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Oct 18, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 18, 2023 22:37
@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 19, 2023 00:02
@Tobias-Fischer Tobias-Fischer mentioned this pull request Oct 19, 2023
Merged
5 tasks
@Tobias-Fischer
Copy link
Contributor Author

Needs conda-forge/flann-feedstock#41

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 21, 2023 19:06
@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer Tobias-Fischer changed the title use fix-cuda-toolkit.patch use fix-cuda-toolkit.patch + flann 1.9.2 Oct 21, 2023
@Tobias-Fischer Tobias-Fischer merged commit 07b0932 into conda-forge:main Oct 21, 2023
@Tobias-Fischer Tobias-Fischer deleted the fix-cuda-toolkit branch October 21, 2023 21:17
@Tobias-Fischer Tobias-Fischer mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tobias-Fischer