Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test project validator #5076

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Test project validator #5076

merged 2 commits into from
Mar 19, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Mar 18, 2024

(sharded out of #5072 for scope's sake)

Problem:

The project validator is not tested itself.

Fix:

  1. Refactor the validator and its logic so it's easier to test and to follow (it can and will get complicated)
  2. Simplify it a bit so it always returns consistent status codes (404 by default, 403 if the project is not accessible but the user can request access to it and the related flag is set)
  3. Test it

@ruggi
test project validator and make it more testable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
44de249
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Mar 18, 2024 •
edited
Loading

Job #11109: Bundle Size — 63.25MiB (~-0.01%).

e71739d(current) vs 2296c28 master#11106(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #11109		      Baseline
Job #11106
Regression  Initial JS 50.43MiB(~+0.01%) 50.43MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.9% 21.42%
No change  Chunks 40 40
No change  Assets 44 44
No change  Modules 4467 4467
No change  Duplicate Modules 605 605
No change  Duplicate Code 31.97% 31.97%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #11109		      Baseline
Job #11106
Regression  JS 63.24MiB (~+0.01%) 63.24MiB
Improvement  HTML 14.15KiB (-0.44%) 14.21KiB

View job #11109 report View chore/test-project-validator branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@ruggi ruggi merged commit 8b5a92d into master Mar 19, 2024
17 checks passed
@ruggi ruggi deleted the chore/test-project-validator branch March 19, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liady liady

@balazsbajorics balazsbajorics

@bkrmendy bkrmendy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruggi @balazsbajorics @liady @bkrmendy