-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a project is not collaborative, don't check user access #5072
Conversation
Job #11117: Bundle Size — 63.25MiB (~-0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #11117 report View feat/project-access-collaborativ... branch activity View project dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to discuss how much we want to rely on FGA permissions system and how much on our DB access levels (since we need to keep them in sync).
Today changing access levels toggles on/off permissions for user:*
, and that's the only "source of truth" for validation. If we want to also add the layer of actually checking project access level in the DB, we just need to see that we don't have edge cases there (for example maybe we'll have a permission that we do want to allow for private projects in the future)
} | ||
|
||
// if the project is collaborative… | ||
if (ownership.accessLevel === AccessLevel.COLLABORATIVE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want a WITH_LINK
access level?
# Conflicts: # utopia-remix/app/handlers/validators.spec.ts # utopia-remix/app/handlers/validators.ts
Fix #5071
Problem:
Projects that are not collaborative (or public for that matter) should not be accessible by anybody (except owners), even if those users were given access permissions while the project was collaborative.
Fix:
On the side…