Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nodejs #632

Merged
merged 7 commits into from
Jan 15, 2020
Merged

Add Nodejs #632

merged 7 commits into from
Jan 15, 2020

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Jan 9, 2020

Specify library name and version: nodejs/13.6.0

Version 12.14.1 is LTS
Version 13.6.0 is the latest

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries added the blocked Affected by an external issue and waiting until it is solved label Jan 9, 2020
@uilianries uilianries requested review from SSE4 and danimtb January 9, 2020 23:33
@uilianries uilianries marked this pull request as ready for review January 9, 2020 23:33
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Some configurations of 'nodejs/12.14.1' failed in build 2 (13569c83c52b60bbb4b5d30fb6d962faf7d6f4a1):

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONANDATA.YML FORMAT (KB-H030)] Additional entry ['os'] not allowed in 'sources':'12.14.1' of conandata.yml (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H030)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Some configurations of 'nodejs/12.14.1' failed in build 3 (6810d76b9524c5e4c42ab2d1385be0b434770ced):

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Empty package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=Linux, compiler=None (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@uilianries uilianries removed the blocked Affected by an external issue and waiting until it is solved label Jan 10, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 4 (adc6104e440c8e80ca6f0728f83b3c18846e5a3d)! 😊

@uilianries
Copy link
Member Author

BTW I tried to build from sources ... On Linux it took 2h to build only one profile 😱

@danimtb danimtb requested a review from czoido January 10, 2020 13:07
@czoido
Copy link
Contributor

czoido commented Jan 10, 2020

Hi @uilianries, just one question: shouldn't we take the 32-bit versions into account or maybe raise an invalid configuration if there are no installers available?

Copy link
Contributor

@czoido czoido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the thing about adding the 32 bit versions

@uilianries
Copy link
Member Author

@czoido there are installers for 32-bit, but not for all OS. As we dropped 32-bit support, I'm going to raise and error when trying to install such platform

@uilianries
Copy link
Member Author

@danimtb danimtb merged commit 1ad9c66 into conan-io:master Jan 15, 2020
@CroydonBot CroydonBot deleted the nodejs branch January 15, 2020 13:00
@p-groarke p-groarke mentioned this pull request Sep 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants