Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] libraries needed to update conan/examples: emsdk, imgui, glfw, glew, folly #620

Closed
czoido opened this issue Jan 8, 2020 · 7 comments · Fixed by #6163
Closed
Assignees

Comments

@czoido
Copy link
Contributor

czoido commented Jan 8, 2020

We are in the process of updating the conan examples repo to use recipes from conan center index and updating Windows configurations to vs 2019 but there are some libraries missing: emsdk, imgui, glfw, glew, folly
Without them, the update to c3i is not possible and the ci fails.

@czoido
Copy link
Contributor Author

czoido commented Jan 9, 2020

@uilianries, @SSE4, could you please have a look at these recipes, to see if they can be included in c3i so we can update the examples repository and Conan documentation soon?

@ericLemanissier
Copy link
Contributor

ericLemanissier commented Jan 9, 2020

glfw and glew require https://github.com/bincrafters/conan-mesa and https://github.com/bincrafters/conan-x11/, the main problem with conan-x11 is that it's a "meta-recipe" which generates a lot of packages (49), so it does not fit the CCI structure. Also, it does not have proper tests currently.
imgui seems easily transferable. folly can be transferred once we transfer libiberty
EDIT: imgui already has a PR: #625

@uilianries uilianries mentioned this issue Jan 9, 2020
4 tasks
@SSE4
Copy link
Contributor

SSE4 commented Jan 13, 2021

I think we have most of the things mentioned, probably except emsdk

@solvingj
Copy link
Contributor

solvingj commented Feb 22, 2021

@SSE4 do you see any issue with submitting emscripten_installer to CCI?

We're also going to do emscripten stuff here, and it would be better if it were a supported CCI package.

conan-io/conan#7816

@SSE4
Copy link
Contributor

SSE4 commented Sep 26, 2021

sorry, completely missed the question :)
late is better than never, so answering
I personally don't see any problem with emsdk
in fact, we already have PR submitted: #6163
the only blocking/tentative thing is that emsdk downloads its own installations of nodejs, python, etc.
this might be tricky to bypass, or we may just agree to live with it for now

@SSE4
Copy link
Contributor

SSE4 commented Sep 26, 2021

already in CCI:

glew/2.1.0
glew/2.2.0
imgui/1.74
imgui/1.75
imgui/1.76
imgui/1.77
imgui/1.78
imgui/1.79
imgui/1.80
imgui/1.81
imgui/1.82
imgui/1.83
imgui/1.84.1
imgui/1.84.2
glfw/3.3.2
glfw/3.3.3
glfw/3.3.4 
folly/2019.10.21.00
folly/2020.08.10.00

so emsdk is the last nail

@jgsogo jgsogo mentioned this issue Sep 27, 2021
4 tasks
@jgsogo
Copy link
Contributor

jgsogo commented Sep 27, 2021

I'm adding the closes keyword from PR #6163 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants