Animated transformation support #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add interface for animated transformation. - Register post processor in ImageDecoderDecoder.kt to invoke transformation after decoding. - Invoke transformation after drawing to software canvas in case of MovieDrawable.kt - Add extension method on ImageRequest.Builder to allow adding AnimatedTransformation.kt
- Remove extra line at the end of Gifs.kt
- Add test to check rounded corner transformation is producing correct result on an image.
- Modify instrumentation test to verify gif, heif and webp transformations.
…eature/gif-transformation
- Minor code formatting.
colinrtwhite
reviewed
Feb 6, 2021
coil-gif/src/androidTest/java/coil/transform/AnimatedTransformationTest.kt
Outdated
Show resolved
Hide resolved
colinrtwhite
reviewed
Feb 6, 2021
coil-gif/src/androidTest/java/coil/transform/AnimatedTransformationTest.kt
Outdated
Show resolved
Hide resolved
colinrtwhite
reviewed
Feb 6, 2021
colinrtwhite
reviewed
Feb 6, 2021
coil-gif/src/main/java/coil/transform/AnimatedTransformation.kt
Outdated
Show resolved
Hide resolved
colinrtwhite
reviewed
Feb 6, 2021
coil-gif/src/main/java/coil/transform/AnimatedTransformation.kt
Outdated
Show resolved
Hide resolved
colinrtwhite
reviewed
Feb 6, 2021
colinrtwhite
reviewed
Feb 6, 2021
|
Awesome, thanks for implementing this! To fix the API check error run |
- Code refactoring and PR review suggestions - Fix instrumentation test failing for HEIF and Webp transformation below API level 28 - API dump
- Fix class not found error for rounded rectangle below API level 21 in RoundedCornerTransformation.kt
colinrtwhite
reviewed
Feb 8, 2021
coil-gif/src/main/java/coil/transform/AnimatedTransformation.kt
Outdated
Show resolved
Hide resolved
|
Please convert this to a non-draft PR when you're ready for it to be merged. |
- Remove size from transform call as it was unnecessary.
colinrtwhite
approved these changes
Feb 12, 2021
colinrtwhite
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Support for gif transformation - Add interface for animated transformation. - Register post processor in ImageDecoderDecoder.kt to invoke transformation after decoding. - Invoke transformation after drawing to software canvas in case of MovieDrawable.kt - Add extension method on ImageRequest.Builder to allow adding AnimatedTransformation.kt * Code formatting - Remove extra line at the end of Gifs.kt * Instrumentation test - Add test to check rounded corner transformation is producing correct result on an image. * Instrumentation test - Modify instrumentation test to verify gif, heif and webp transformations. * Bug fix - Fix bug related to transformation in GifDecoder.kt where transformation rendering position was off by applying transformation after drawing on software canvas rather than while drawing on canvas. * Code refactoring - Minor code formatting. * PR review and instrumentation test fixes - Code refactoring and PR review suggestions - Fix instrumentation test failing for HEIF and Webp transformation below API level 28 - API dump * Fix the instrumentation test failure - Fix class not found error for rounded rectangle below API level 21 in RoundedCornerTransformation.kt * Transformation API change - Remove size from transform call as it was unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176