Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transformations in coil-gif #176

Closed
damiancioo opened this issue Nov 18, 2019 · 6 comments · Fixed by #659
Closed

Add support for transformations in coil-gif #176

damiancioo opened this issue Nov 18, 2019 · 6 comments · Fixed by #659
Labels
enhancement New feature or request help wanted Issues that are up for grabs + are good candidates for community PRs

Comments

@damiancioo
Copy link

Is your feature request related to a problem? Please describe.
Right now I want to use coil's coil gif extension together with transformations, it seems that Gif extension is ignoring them

I did:

Coil.setDefaultImageLoader(ImageLoader(this) {
            componentRegistry {
                add(GifDecoder())
            }
        })

and load image with:

imageView.load(R.drawable.some_gif_image) {
                placeholder(R.drawable.placeholder)
                transformations(CircleCropTransformation())
                repeatCount(0)
            }

Describe the solution you'd like
Gid extension should apply transformations

@damiancioo damiancioo added the enhancement New feature or request label Nov 18, 2019
@colinrtwhite
Copy link
Member

Yep, I'd like to add support for this as well, however it'll need to account for ImageDecoder and more specifically PostProcessor.

PostProcessor has some key differences from Transformations:

  • It passes a Canvas instead of a Bitmap.
  • The canvas behaves as if the decoded image data already exists on the canvas.

Unfortunately, I won't be able to work on this for a while, but PRs welcome.

@colinrtwhite colinrtwhite added the help wanted Issues that are up for grabs + are good candidates for community PRs label Nov 18, 2019
@sagar-viradiya
Copy link
Contributor

@colinrtwhite I have made suggested changes and this seems to be working fine. PR coming soon!

@prithivraj
Copy link

Hi Instacart!
This issue blocks us from switching to Coil.
Is there a planned release date for the next version?

@colinrtwhite
Copy link
Member

@prithivraj Yep! The next release should be out either tomorrow or early next week - just need to fix one bug on master.

@colinrtwhite
Copy link
Member

The release is delayed slightly, unfortunately as I haven't been able to solve the issue on master yet. In the meantime you can use the snapshot builds if you need the latest changes now.

@prithivraj
Copy link

Thanks for the update Colin, I've checked with the snapshot version, everything looks good and working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Issues that are up for grabs + are good candidates for community PRs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants