Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Adding infra. for L1T object scaling constants from DB" #32436

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Revert "Adding infra. for L1T object scaling constants from DB" #32436

merged 1 commit into from
Dec 14, 2020

Conversation

silviodonato
Copy link
Contributor

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Dec 10, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32436/20321

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

CondCore/HLTPlugins
CondFormats/DataRecord
CondFormats/HLTObjects

@cmsbuild, @yuanchao, @fwyzard, @christopheralanwest, @Martin-Grunewald, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f84a5c/11533/summary.html
CMSSW: CMSSW_11_3_X_2020-12-10-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747284
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2747255
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@smuzaffar smuzaffar mentioned this pull request Dec 11, 2020
Merged
@Martin-Grunewald
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 11fb37a into master Dec 14, 2020
@christopheralanwest
Copy link
Contributor

+1

This was referenced Dec 14, 2020
Merged
Merged
Merged
@smuzaffar smuzaffar deleted the revert-32137-PR-112X-HLTL1T branch January 13, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved db-pending hlt-approved orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_3_X
Development

Successfully merging this pull request may close these issues.
4 participants
@silviodonato @cmsbuild @Martin-Grunewald @christopheralanwest