-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding infra. for L1T object scaling constants from DB -- 11_1_X #32320
Conversation
A new Pull Request was created by @trtomei (Thiago Tomei) for CMSSW_11_1_X. It involves the following packages: CondCore/HLTPlugins @cmsbuild, @yuanchao, @fwyzard, @christopheralanwest, @tocheng, @Martin-Grunewald, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
hold I would like to wait for comments from L1 experts on this proposal prior to merging. In fact, probably the PR to master, while technically fine, probably should have waited for their input. |
Pull request has been put on hold by @christopheralanwest |
@christopheralanwest do you have any news from the L1 experts ? |
Of course the code would be useful - otherwise we would not have submitted
the PRs in the first place.
The issue is that the L1T DPG is not keen in supporting it.
|
We were told this was going to be discussed between the L1T and HLT coordinators, but apparently that hasn't happened yet... |
For the TDR, we decided to go a different whilst this is hashed. We are going to live with the object scaling constants written in the python configuration files. AlCa may close this PR, and revert #32137 (effectively deleting it from 11_3_X). |
This PR adds initial infrastructure for the L1T-HLT interface for Phase2.
We add a new CondFormat for the L1TObjScalingConstants and a new DataRecord to hold that new format in a DB.
CondFormats/HLTObjects/test/testSerializationHLTObjects.cpp
and ran
scram b runtests
with success!runTheMatrix.py -l limited -i all --ibeos
with success.This is a backport of #32137 . We need this to have a complete version of the Phase-2 HLT menu in CMSSW_11_1_X .