adjust default value of credhub_alerts.scrape_too_old.threshold #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently used version of the credhub_exporter uses 6h as the default scraping interval [1,2]. This commit adjusts the default value of scrape_too_old for credhub_alerts to 6h, in order to not throw any alerts for a default deployment. [1] https://github.com/orange-cloudfoundry/credhub_exporter/blob/v0.2.2/README.md#flags [2] https://github.com/orange-cloudfoundry/credhub_exporter/blob/v0.2.2/credhub_exporter.go#L65
|
@psycofdj Do you mind taking a look at this PR please? |
|
This is a 100% legitimate fix. On my production instances we also have set 21600 (6h) with an ops-file. I've introduced this inconsistency in PR #385 when I changed the scrapping strategy (oupsy) |
|
Thanks @psycofdj for reviewing it! Thanks @schemmeltobi for the fix! |
schemmeltobi
deleted the
fix/adjust-default-time-of-scrape-too-old-alert-threshold
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used version of the credhub_exporter uses 6h as the default
scraping interval [1,2]. This commit adjusts the default value of
scrape_too_old for credhub_alerts to 6h, in order to not throw any
alerts for a default deployment.
[1] https://github.com/orange-cloudfoundry/credhub_exporter/blob/v0.2.2/README.md#flags
[2] https://github.com/orange-cloudfoundry/credhub_exporter/blob/v0.2.2/credhub_exporter.go#L65