Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog
This PR includes:
credhub_exporter
credhub_exporter
bpm
spec
matching credhub_exporter's flags default valuescredhub_alerts
max_over_time
calls in alert expressions since metrics can now be scrapped every few minutescredhub_dashboards
max_over_time
calls in queriesindex
column that was already present in metricsmanifests/operators/monitor-bosh.yml
: lower credhub_exporter scrape interval and timeout from30m
and4m
to4m
and2m
respectivelymanifests/operators/use-bpm.yml
: add ops-file that adds bpm job toprometheus2
instance which is now required bycredhub_exporter
about bpm
I felt more comfortable generating a
bpm
configuration than editing the existingcredhub_exporter_ctl
template which become less and less readable. However I would totally understand that introducingbpm
to the release is a problem and I can rework the PR to get back to a<job>_ctl
script.blobs
If the PR is accepted, the new version of
credhub_exporter
must be added to the blobs