Allow multiple apps in manifests #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcapizzi
force-pushed
the
multi-app-manifests
branch
from
32ebd72 to
4a2a3e8
Compare
And fix the behaviour of creating a web process during manifest application or app creation to match cf on VMs Issue: #1661 Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
Test for e.g. app memory > 0 were failing for the wrong reason. 0 fails to be parsed as an amount with a unit by the bytefmt library as it doesn't contain a byte unit. Adding tests for missing units showed the errors message could be improved by splitting validation into that for having a unit and that for being a positive amount. go-playground/validator doesn't allow us to give the true path to the erroneous value unfortunately. E.g. the cf on vms errors would be along the lines of `For application 'test-app': Process "web": Disk quota must use a supported unit: B, K, KB, M, MB, G, GB, T, or TB`. So best effort on field identification for now, until we can rethink the validation code.
kieron-dev
force-pushed
the
multi-app-manifests
branch
from
fcab7f7 to
8135b70
Compare
| @@ -45,20 +45,25 @@ func NewManifest(domainRepo shared.CFDomainRepository, defaultDomainName string, | |||
| } | |||
| } | |||
|
|
|||
| func (a *Manifest) Apply(ctx context.Context, authInfo authorization.Info, spaceGUID string, manifest payloads.Manifest) error { | |||
| func (a *Manifest) Apply(ctx context.Context, authInfo authorization.Info, spaceGUID string, manifesto payloads.Manifest) error { | |||
There was a problem hiding this comment.
Hmm, was that intentional? Not a big deal, just curious.
georgethebeatle
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1661
What is this change about?
Allow the list of apps in a space manifest to have more than 1 entry.
Also fix the behaviour of creating a web process during manifest application or app creation to match cf on VMs. I.e. the web process is created at the same time as the app.
Does this PR introduce a breaking change?
Note that the web app is created earlier now, rather than when starting the app.
Acceptance Steps
See story
Tag your pair, your PM, and/or team
@gcapizzi