Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-app manifests #1661

Closed
danail-branekov opened this issue Sep 19, 2022 · 0 comments
Closed

Support multi-app manifests #1661

danail-branekov opened this issue Sep 19, 2022 · 0 comments
Assignees
@gcapizzi
Labels
space-manifest
Milestone
v0.7

Comments

@danail-branekov
Copy link
Member

The current manifest action only considers the first application when applying
the manifest. There is even a
validation
that returns an error if the manifest contains more than one application.

On CF on VMs multiple app mnifests work OK. We should therefore remove this
validation and change the manifest action to process all the applications in
the manifest.
@gcapizzi gcapizzi moved this to 🇪🇺 To do in Korifi - Backlog Nov 29, 2022
@gcapizzi gcapizzi added this to the v0.7 milestone Jan 24, 2023
@gcapizzi gcapizzi moved this from 🇪🇺 To do to 🔄 In progress in Korifi - Backlog Jan 26, 2023
@gcapizzi gcapizzi self-assigned this Jan 26, 2023
gcapizzi added a commit that referenced this issue Jan 27, 2023
@gcapizzi
Allow multiple apps in manifest
88edaa9 
Also adjust behaviour to create the web process when applying an manifest
or creating an app via the POST /v3/apps endpoint.

Issue: #1661
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
gcapizzi added a commit that referenced this issue Jan 27, 2023
@gcapizzi
Allow multiple apps in manifest
f0d6574 
Also adjust behaviour to create the web process when applying an manifest
or creating an app via the POST /v3/apps endpoint.

Issue: #1661
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
gcapizzi added a commit that referenced this issue Jan 27, 2023
@gcapizzi
Allow multiple apps in manifests
32ebd72 
And fix the behaviour of creating a web process during manifest
application or app creation to match cf on VMs

Issue: #1661
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
@kieron-dev kieron-dev mentioned this issue Jan 27, 2023
Merged
gcapizzi added a commit that referenced this issue Jan 27, 2023
@gcapizzi
Allow multiple apps in manifests
4a2a3e8 
And fix the behaviour of creating a web process during manifest
application or app creation to match cf on VMs

Issue: #1661
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
kieron-dev pushed a commit that referenced this issue Jan 30, 2023
@gcapizzi
Allow multiple apps in manifests
114fe00 
And fix the behaviour of creating a web process during manifest
application or app creation to match cf on VMs

Issue: #1661
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
@kieron-dev kieron-dev moved this from 🔄 In progress to ⏳ Review in progress in Korifi - Backlog Jan 30, 2023
georgethebeatle pushed a commit that referenced this issue Jan 31, 2023
@gcapizzi @georgethebeatle
Allow multiple apps in manifests
3c5a58c 
And fix the behaviour of creating a web process during manifest
application or app creation to match cf on VMs

Issue: #1661
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
@kieron-dev kieron-dev moved this from ⏳ Review in progress to ⌛ Reviewer approved in Korifi - Backlog Jan 31, 2023
@gcapizzi gcapizzi closed this as completed Feb 6, 2023
@github-project-automation github-project-automation bot moved this from ⌛ Reviewer approved to ✅ Done in Korifi - Backlog Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcapizzi gcapizzi

Labels
space-manifest
Projects
Korifi - Backlog
Archived in project
Milestone
v0.7
Development

No branches or pull requests
2 participants
@gcapizzi @danail-branekov