Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3505451] Added attributes prop to field message. #480

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

richardgaunt
Copy link
Collaborator

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added attributes prop to field message so we can link to error messages.

Note: there are other accessibility connections from field element to message provided within drupal theme in field attributes.

Screenshots

ID added
image

@richardgaunt richardgaunt self-assigned this Feb 13, 2025
Copy link

github-actions bot commented Feb 13, 2025

@github-actions github-actions bot temporarily deployed to pull request February 13, 2025 06:59 Inactive
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.51%. Comparing base (41afc32) to head (cd5fc6e).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   12.51%   12.51%           
=======================================
  Files          36       36           
  Lines        1119     1119           
  Branches      251      251           
=======================================
  Hits          140      140           
  Misses        789      789           
  Partials      190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request February 20, 2025 02:03 Inactive
@richardgaunt richardgaunt force-pushed the 3505451--update-field-message-props branch from 3805c13 to cd5fc6e Compare February 20, 2025 05:37
@github-actions github-actions bot temporarily deployed to pull request February 20, 2025 05:39 Inactive
@richardgaunt richardgaunt merged commit 4adf2d9 into main Feb 20, 2025
4 checks passed
@richardgaunt richardgaunt deleted the 3505451--update-field-message-props branch February 20, 2025 06:04
@fionamorrison23 fionamorrison23 added this to the 1.10 milestone Feb 23, 2025
@fionamorrison23 fionamorrison23 added State: Done The issue is complete and waiting for a release and removed PR: Needs review Pull request needs a review from assigned developers labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Done The issue is complete and waiting for a release
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants