Issue #3505451 by richardgaunt, fionamorrison23, alan.cole: Errors are not linking to error messages in radios and checkboxes #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardgaunt
commented
Feb 13, 2025
| $element_id = $element['#id'] ?? $element['#attributes']['data-drupal-selector'] ?? ''; | ||
| if (!empty($element_id)) { | ||
| $element_id .= '--error-message'; | ||
| $variables['message']['attributes'] = new Attribute(['id' => $element_id]); |
There was a problem hiding this comment.
Note we add the ID for the message and the aria-described-by for the form element
richardgaunt
added
the
State: Needs review
github-actions
bot
added
State: CONFLICT
and removed
State: Needs review
richardgaunt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Issue #123456 by drupal_org_username: Issue titleChangedsection about WHY something was done if this was not a normal implementationChanged
See civictheme/uikit#480 for UI Kit update
Screenshots
Updated preprocessing with new field.twig template
