Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[#294] Slider is broken when large images are used." #430

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

richardgaunt
Copy link
Collaborator

@richardgaunt richardgaunt commented Nov 25, 2024

This reverts commit 6518c1c.

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Revert fix as causes other problems.

Screenshots

@richardgaunt richardgaunt changed the title Revert "[#294] Slider is broken when large images are used. (#298)" Revert "[#294] Slider is broken when large images are used." Nov 25, 2024
@richardgaunt richardgaunt added the PR: Needs review Pull request needs a review from assigned developers label Nov 25, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 03:59 Inactive
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 13.75%. Comparing base (6518c1c) to head (1f03c47).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
components/03-organisms/slider/slider.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   13.77%   13.75%   -0.03%     
==========================================
  Files          27       27              
  Lines        1299     1301       +2     
  Branches      309      308       -1     
==========================================
  Hits          179      179              
- Misses        902      904       +2     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@richardgaunt richardgaunt merged commit 111194f into main Nov 25, 2024
6 of 8 checks passed
@richardgaunt richardgaunt deleted the revert-slider-fix branch November 25, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant