Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#294] Slider is broken when large images are used. #298

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Jun 24, 2024

Closes #294

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Fixed Image stretches the Slider height because it is not vertically constrained.
  2. The horizontal layout does not follow grid.

Screenshots

Screenshot 2024-06-24 at 7 19 12 PM
Screenshot 2024-06-24 at 7 19 27 PM

@joshua-salsadigital joshua-salsadigital added the PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request label Jun 24, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 13:52 Inactive
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 13.88%. Comparing base (f924c74) to head (7a21787).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
components/03-organisms/slider/slider.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   13.86%   13.88%   +0.02%     
==========================================
  Files          27       27              
  Lines        1291     1289       -2     
  Branches      307      308       +1     
==========================================
  Hits          179      179              
+ Misses        895      893       -2     
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request October 24, 2024 01:33 Inactive
@febdao febdao added PR: Needs review Pull request needs a review from assigned developers and removed PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request labels Oct 24, 2024
@febdao febdao removed the request for review from AlexSkrypnyk October 24, 2024 08:35
@richardgaunt richardgaunt added the State: Needs more work The issue requires more work label Nov 13, 2024
Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@febdao febdao removed the State: Needs more work The issue requires more work label Nov 17, 2024
@febdao febdao requested a review from richardgaunt November 17, 2024 10:29
@github-actions github-actions bot temporarily deployed to pull request November 17, 2024 10:33 Inactive
Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@febdao Thanks this looks good.

@richardgaunt richardgaunt merged commit 6518c1c into main Nov 18, 2024
6 of 7 checks passed
@richardgaunt richardgaunt deleted the feature/294-slider-issue branch November 18, 2024 05:45
richardgaunt added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider is broken when large images are used
3 participants