-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#294] Slider is broken when large images are used. #298
Conversation
…ically constrained.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 13.86% 13.88% +0.02%
==========================================
Files 27 27
Lines 1291 1289 -2
Branches 307 308 +1
==========================================
Hits 179 179
+ Misses 895 893 -2
Partials 217 217 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@febdao The linting is failing please fix.
https://github.com/civictheme/uikit/actions/runs/11495620217/job/31995522271?pr=298
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@febdao Thanks this looks good.
Closes #294
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.
Changed
section about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
Screenshots