Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#330] Fixed card link arrows being read-out by screen readers and tabbed to. #331

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

alan-cole
Copy link
Collaborator

#330

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Ignore arrow links from tabbing and screen readers.

Screenshots

@alan-cole alan-cole self-assigned this Jul 25, 2024
@alan-cole alan-cole added the PR: Needs review Pull request needs a review from assigned developers label Jul 25, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 23:41 Inactive
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.92%. Comparing base (b512e9a) to head (a77a4fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   13.92%   13.92%           
=======================================
  Files          27       27           
  Lines        1285     1285           
  Branches      306      306           
=======================================
  Hits          179      179           
  Misses        890      890           
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk changed the title [#330] Ignore arrow links from tabbing and screen readers. [#330] Fixed card link arrows being read-out by screen readers and tabbed to. Jul 29, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 1a25a3f into main Jul 29, 2024
7 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/a11y-card-double-link branch July 29, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants