Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments in componenet twig files is not easily parsable due to inconsistencies. #342

Closed
alan-cole opened this issue Aug 19, 2024 · 1 comment
Closed

Comments in componenet twig files is not easily parsable due to inconsistencies. #342

alan-cole opened this issue Aug 19, 2024 · 1 comment
Labels
Type: Defect Issue is a defect
Milestone
1.9

Comments

@alan-cole
Copy link
Collaborator

Summary

Comments in componenet twig files is not easily parsable due to inconsistencies.

Steps to reproduce

View twig file header on logo, tabs, video-player, navigation, webform.

Observed outcome

Incorrect spelling of 'boolean', indentation, types.

Expected outcome

Consistent and correct spelling of 'boolean', indentation, types.
@alan-cole alan-cole added the Type: Defect Issue is a defect label Aug 19, 2024
richardgaunt pushed a commit that referenced this issue Sep 4, 2024
@alan-cole
[#342] Twig comment changes required for generating components. (#343)
f88f578
@github-project-automation github-project-automation bot moved this to Todo in UI Kit Sep 5, 2024
@fionamorrison23 fionamorrison23 added this to the 1.9 milestone Sep 5, 2024
@richardgaunt
Copy link
Collaborator

@alan-cole I have merged your PR - I believe this closes this issue.

@fionamorrison23 fionamorrison23 moved this from Todo to Done in UI Kit Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Issue is a defect
Projects
UI Kit
Status: Done
Milestone
1.9
Development

No branches or pull requests
3 participants
@alan-cole @richardgaunt @fionamorrison23