Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#342] Twig comment changes required for generating components. #343

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

alan-cole
Copy link
Collaborator

These changes were taken from: https://git.drupalcode.org/project/demo_design_system/-/merge_requests/3/

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Consistent and correct spelling of 'boolean', indentation, types.

Screenshots

@alan-cole alan-cole self-assigned this Aug 19, 2024
@alan-cole alan-cole added the PR: Needs review Pull request needs a review from assigned developers label Aug 19, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request August 19, 2024 00:09 Inactive
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.92%. Comparing base (50527f3) to head (2aab6e2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   13.92%   13.92%           
=======================================
  Files          27       27           
  Lines        1285     1285           
  Branches      306      306           
=======================================
  Hits          179      179           
  Misses        890      890           
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardgaunt richardgaunt self-requested a review September 4, 2024 11:51
Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clearup @alan-cole

@richardgaunt richardgaunt merged commit f88f578 into main Sep 4, 2024
8 checks passed
@richardgaunt richardgaunt deleted the feature/comment-cleanup branch September 4, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants